[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] hw/cxl: Use a switch to explicitly check size in caps
From: |
Fan Ni |
Subject: |
Re: [PATCH v2 1/4] hw/cxl: Use a switch to explicitly check size in caps_reg_read() |
Date: |
Mon, 18 Sep 2023 16:23:09 +0000 |
On Fri, Sep 15, 2023 at 06:04:15PM +0100, Jonathan Cameron wrote:
> Bring this read function inline with the others that do
> check for unexpected size values.
>
> Also reduces line lengths to sub 80 chars.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Fan Ni <fan.ni@samsung.com>
> hw/cxl/cxl-device-utils.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/hw/cxl/cxl-device-utils.c b/hw/cxl/cxl-device-utils.c
> index 517f06d869..cd0c45a2ed 100644
> --- a/hw/cxl/cxl-device-utils.c
> +++ b/hw/cxl/cxl-device-utils.c
> @@ -32,10 +32,13 @@ static uint64_t caps_reg_read(void *opaque, hwaddr
> offset, unsigned size)
> {
> CXLDeviceState *cxl_dstate = opaque;
>
> - if (size == 4) {
> - return cxl_dstate->caps_reg_state32[offset /
> sizeof(*cxl_dstate->caps_reg_state32)];
> - } else {
> - return cxl_dstate->caps_reg_state64[offset /
> sizeof(*cxl_dstate->caps_reg_state64)];
> + switch (size) {
> + case 4:
> + return cxl_dstate->caps_reg_state32[offset / size];
> + case 8:
> + return cxl_dstate->caps_reg_state64[offset / size];
> + default:
> + g_assert_not_reached();
> }
> }
>
> --
> 2.39.2
>