|
From: | David Hildenbrand |
Subject: | Re: [RFC PATCH v2 07/21] i386/pc: Drop pc_machine_kvm_type() |
Date: | Thu, 21 Sep 2023 10:51:34 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 14.09.23 05:51, Xiaoyao Li wrote:
pc_machine_kvm_type() was introduced by commit e21be724eaf5 ("i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode") to do Xen specific initialization by utilizing kvm_type method. commit eeedfe6c6316 ("hw/xen: Simplify emulated Xen platform init") moves the Xen specific initialization to pc_basic_device_init(). There is no need to keep the PC specific kvm_type() implementation anymore.
So we'll fallback to kvm_arch_get_default_type(), which simply returns 0.
On the other hand, later patch will implement kvm_type() method for all x86/i386 machines to support KVM_X86_SW_PROTECTED_VM.
^ I suggest dropping that and merging that patch ahead-of-time as a simple cleanup.
Reviewed-by: David Hildenbrand <david@redhat.com> -- Cheers, David / dhildenb
[Prev in Thread] | Current Thread | [Next in Thread] |