[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/52] migration/rdma: Clean up qemu_rdma_poll()'s return typ
|
From: |
Zhijian Li (Fujitsu) |
|
Subject: |
Re: [PATCH 01/52] migration/rdma: Clean up qemu_rdma_poll()'s return type |
|
Date: |
Thu, 21 Sep 2023 08:52:13 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 18/09/2023 22:41, Markus Armbruster wrote:
> qemu_rdma_poll()'s return type is uint64_t, even though it returns 0,
> -1, or @ret, which is int. Its callers assign the return value to int
> variables, then check whether it's negative. Unclean.
>
> Return int instead.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
- [PATCH 00/52] migration/rdma: Error handling fixes, Markus Armbruster, 2023/09/18
- [PATCH 01/52] migration/rdma: Clean up qemu_rdma_poll()'s return type, Markus Armbruster, 2023/09/18
- [PATCH 12/52] migration/rdma: Drop qemu_rdma_search_ram_block() error handling, Markus Armbruster, 2023/09/18
- [PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type, Markus Armbruster, 2023/09/18
- [PATCH 27/52] migration/rdma: Drop superfluous assignments to @ret, Markus Armbruster, 2023/09/18
- [PATCH 20/52] migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port, Markus Armbruster, 2023/09/18