[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 38/52] migration/rdma: Convert qemu_rdma_write_flush() to Err
From: |
Zhijian Li (Fujitsu) |
Subject: |
Re: [PATCH 38/52] migration/rdma: Convert qemu_rdma_write_flush() to Error |
Date: |
Tue, 26 Sep 2023 01:56:16 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 18/09/2023 22:41, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the error), there is no error to
> report, i.e. the report is bogus.
>
> qio_channel_rdma_writev() violates this principle: it calls
> error_report() via qemu_rdma_write_flush(). I elected not to
> investigate how callers handle the error, i.e. precise impact is not
> known.
>
> Clean this up by converting qemu_rdma_write_flush() to Error.
>
> Necessitates setting an error when qemu_rdma_write_one() failed.
> Since this error will go away later in this series, simply use "FIXME
> temporary error message" there.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
- [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages, (continued)
- [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages, Markus Armbruster, 2023/09/18
- [PATCH 41/52] migration/rdma: Convert qemu_rdma_post_send_control() to Error, Markus Armbruster, 2023/09/18
- [PATCH 17/52] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE(), Markus Armbruster, 2023/09/18
- [PATCH 38/52] migration/rdma: Convert qemu_rdma_write_flush() to Error, Markus Armbruster, 2023/09/18
- Re: [PATCH 38/52] migration/rdma: Convert qemu_rdma_write_flush() to Error,
Zhijian Li (Fujitsu) <=
- [PATCH 51/52] migration/rdma: Use error_report() & friends instead of stderr, Markus Armbruster, 2023/09/18
- [PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values, Markus Armbruster, 2023/09/18
- [PATCH 16/52] migration/rdma: Fix io_writev(), io_readv() methods to obey contract, Markus Armbruster, 2023/09/18