[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 51/52] migration/rdma: Use error_report() & friends instead o
|
From: |
Zhijian Li (Fujitsu) |
|
Subject: |
Re: [PATCH 51/52] migration/rdma: Use error_report() & friends instead of stderr |
|
Date: |
Tue, 26 Sep 2023 06:35:27 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 18/09/2023 22:42, Markus Armbruster wrote:
> if (local->nb_blocks != nb_dest_blocks) {
> - fprintf(stderr, "ram blocks mismatch (Number of blocks %d vs %d)
> "
> - "Your QEMU command line parameters are probably "
> - "not identical on both the source and destination.",
> - local->nb_blocks, nb_dest_blocks);
> + error_report("ram blocks mismatch (Number of blocks %d vs %d)",
> + local->nb_blocks, nb_dest_blocks);
> + error_printf("Your QEMU command line parameters are probably "
> + "not identical on both the source and
> destination.");
Why is this one handled specifically? It seems like it would be fine with
error_report().
- Re: [PATCH 15/52] migration/rdma: Ditch useless numeric error codes in error messages, (continued)
- [PATCH 41/52] migration/rdma: Convert qemu_rdma_post_send_control() to Error, Markus Armbruster, 2023/09/18
- [PATCH 17/52] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE(), Markus Armbruster, 2023/09/18
- [PATCH 38/52] migration/rdma: Convert qemu_rdma_write_flush() to Error, Markus Armbruster, 2023/09/18
- [PATCH 51/52] migration/rdma: Use error_report() & friends instead of stderr, Markus Armbruster, 2023/09/18
- Re: [PATCH 51/52] migration/rdma: Use error_report() & friends instead of stderr,
Zhijian Li (Fujitsu) <=
- [PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values, Markus Armbruster, 2023/09/18
- [PATCH 16/52] migration/rdma: Fix io_writev(), io_readv() methods to obey contract, Markus Armbruster, 2023/09/18
- [PATCH 22/52] migration/rdma: Fix rdma_getaddrinfo() error checking, Markus Armbruster, 2023/09/18