[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 14/15] acpi/ghes: Change ghes fill logic to work with only one
From: |
Mauro Carvalho Chehab |
Subject: |
[PATCH v3 14/15] acpi/ghes: Change ghes fill logic to work with only one source |
Date: |
Tue, 12 Nov 2024 11:14:58 +0100 |
Extending to multiple sources require a BIOS pointer to the
beginning of the HEST table, which in turn requires a backward-compatible
code.
So, the current code supports only one source. Ensure that and simplify
the code.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
hw/acpi/ghes.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 8df21bad1165..e7de3b302602 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -393,15 +393,13 @@ static void get_ghes_offsets(uint64_t ghes_addr,
* As the current version supports only one source, the ack offset is
* just sizeof(uint64_t).
*/
- *read_ack_register_addr = ghes_addr +
- ACPI_GHES_ERROR_SOURCE_COUNT * sizeof(uint64_t);
+ *read_ack_register_addr = ghes_addr + sizeof(uint64_t);
}
void ghes_record_cper_errors(const void *cper, size_t len,
uint16_t source_id, Error **errp)
{
uint64_t cper_addr = 0, read_ack_register_addr = 0, read_ack_register;
- uint64_t start_addr;
AcpiGedState *acpi_ged_state;
AcpiGhesState *ags;
@@ -418,11 +416,8 @@ void ghes_record_cper_errors(const void *cper, size_t len,
}
ags = &acpi_ged_state->ghes_state;
- start_addr = le64_to_cpu(ags->hw_error_le);
-
- start_addr += source_id * sizeof(uint64_t);
-
- get_ghes_offsets(start_addr, &cper_addr, &read_ack_register_addr);
+ assert(ACPI_GHES_ERROR_SOURCE_COUNT == 1);
+ get_ghes_offsets(le64_to_cpu(ags->hw_error_le), &cper_addr,
&read_ack_register_addr);
cper_addr = le64_to_cpu(cper_addr);
if (!cper_addr) {
--
2.47.0
- [PATCH v3 10/15] acpi/ghes: don't crash QEMU if ghes GED is not found, (continued)
- [PATCH v3 10/15] acpi/ghes: don't crash QEMU if ghes GED is not found, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 07/15] acpi/ghes: Change the type for source_id, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 05/15] acpi/ghes: Fix acpi_ghes_record_errors() argument, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 15/15] docs: acpi_hest_ghes: fix documentation for CPER size, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 13/15] acpi/ghes: move offset calculus to a separate function, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 12/15] acpi/ghes: better name the offset of the hardware error firmware, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 08/15] acpi/ghes: make the GHES record generation more generic, Mauro Carvalho Chehab, 2024/11/12
- [PATCH v3 14/15] acpi/ghes: Change ghes fill logic to work with only one source,
Mauro Carvalho Chehab <=