[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-9.2] hw/avr/arduino: Check for CPU types in machine_run_b
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH-for-9.2] hw/avr/arduino: Check for CPU types in machine_run_board_init() |
|
Date: |
Mon, 18 Nov 2024 13:07:04 +0000 |
On Mon, 18 Nov 2024 at 13:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Leverage the common code introduced in commit c9cf636d48 ("machine:
> Add a valid_cpu_types property") to check for the single valid CPU
> type. This allows reporting an error for invalid CPUs:
>
> $ qemu-system-avr -M 2009 -cpu avr51-avr-cpu
> qemu-system-avr: Invalid CPU model: avr51
> The only valid type is: avr5
This is a nice user-convenience feature, but why for 9.2?
We haven't bothered to error-check the user specified CPU
before, and we still don't on many (non-avr) board types.
thanks
-- PMM