qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.2] hw/avr/arduino: Check for CPU types in machine_run_b

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-9.2] hw/avr/arduino: Check for CPU types in machine_run_board_init()
Date: Mon, 18 Nov 2024 15:40:17 +0100
User-agent: Mozilla Thunderbird 
On 18/11/24 13:07, Peter Maydell wrote:

On Mon, 18 Nov 2024 at 13:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:


Leverage the common code introduced in commit c9cf636d48 ("machine:
Add a valid_cpu_types property") to check for the single valid CPU
type. This allows reporting an error for invalid CPUs:

   $ qemu-system-avr -M 2009 -cpu avr51-avr-cpu
   qemu-system-avr: Invalid CPU model: avr51
   The only valid type is: avr5


This is a nice user-convenience feature, but why for 9.2?
We haven't bothered to error-check the user specified CPU
before, and we still don't on many (non-avr) board types.


OK to postpone for 10.0 then.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]