Re: [PATCH V3 11/16] migration: cpr-transfer mode

[Steven Sistare]

On 11/19/2024 3:51 PM, Peter Xu wrote:
> On Tue, Nov 19, 2024 at 03:32:55PM -0500, Steven Sistare wrote:
> > This begs the question, should we allow channels to be specified in hmp migrate
> > commands and for -incoming, in a very simple way?  Like with a prefix naming
> > the channel.  And eliminate the -cpr-uri argument. Examples:
> >
> > (qemu) migrate -d main:tcp:0:44444,cpr:unix:cpr.sock
> >
> > qemu -incoming main:tcp:0:44444,cpr:unix:cpr.sock
> > qemu -incoming main:defer,cpr:unix:cpr.sock
>
> IMHO keeping the old syntax working would still be nice to not break
> scripts.  

The channel tag would be optional, so backwards compatible.  Its unambiguous
as long as the channel names are not also protocol names.

> I was thinking we could simply add one more parameter for taking
> cpr uri, like:
>
>      {
>          .name       = "migrate",
>          .args_type  = "detach:-d,resume:-r,uri:s,cpr:s?",
>          .params     = "[-d] [-r] uri [cpr_uri]",
>          .help       = "migrate to URI (using -d to not wait for completion)"
>                       "\n\t\t\t -r to resume a paused postcopy migration",
>                       "\n\t\t\t Setup cpr_uri to migrate with cpr-transfer",
>          .cmd        = hmp_migrate,
>      },

That's fine.

I do like the incoming syntax, though, instead of -cpr-uri.  What do you think?

- Steve