Re: [PATCH-for-10.0 2/6] accel/tcg: Declare local tcg_ops variable in tcg_exec_realizefn()

[Richard Henderson]

On 11/27/24 06:16, Philippe Mathieu-Daudé wrote:
>   bool tcg_exec_realizefn(CPUState *cpu, Error **errp)
>   {
> -    static bool tcg_target_initialized;

Error removing this variable before patch 6.

r~

> +    const TCGCPUOps *tcg_ops = cpu->cc->tcg_ops;
>   
>       if (!tcg_target_initialized) {
>           /* Check mandatory TCGCPUOps handlers */
>   #ifndef CONFIG_USER_ONLY
> -        assert(cpu->cc->tcg_ops->cpu_exec_halt);
> -        assert(cpu->cc->tcg_ops->cpu_exec_interrupt);
> +        assert(tcg_ops->cpu_exec_halt);
> +        assert(tcg_ops->cpu_exec_interrupt);
>   #endif /* !CONFIG_USER_ONLY */
> -        cpu->cc->tcg_ops->initialize();
> +        tcg_ops->initialize();
>           tcg_target_initialized = true;