qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" inst


From: Peter Xu
Subject: [PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" instead
Date: Tue, 13 May 2025 18:09:22 -0400

"info migrate" is the command people would frequently use to query
migration status.  We may not want it to dump global configurations because
dumping the same things over and over won't help.

The globals are just more suitable for a parameter dump instead.  Hence
move it over.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration-hmp-cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 49c26daed3..0034dbe47f 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -58,8 +58,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
 
     info = qmp_query_migrate(NULL);
 
-    migration_global_dump(mon);
-
     if (info->blocked_reasons) {
         strList *reasons = info->blocked_reasons;
         monitor_printf(mon, "Outgoing migration blocked:\n");
@@ -235,6 +233,8 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict 
*qdict)
 {
     MigrationParameters *params;
 
+    migration_global_dump(mon);
+
     params = qmp_query_migrate_parameters(NULL);
 
     if (params) {
-- 
2.49.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]