[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] migration: Allow caps to be set when preempt or multifd
|
From: |
Juraj Marcin |
|
Subject: |
Re: [PATCH 1/3] migration: Allow caps to be set when preempt or multifd cap enabled |
|
Date: |
Wed, 14 May 2025 15:27:25 +0200 |
On 2025-05-13 18:09, Peter Xu wrote:
> With commit 82137e6c8c ("migration: enforce multifd and postcopy preempt to
> be set before incoming"), and if postcopy preempt / multifd is enabled, one
> cannot setup any capability because these checks would always fail.
>
> (qemu) migrate_set_capability xbzrle off
> Error: Postcopy preempt must be set before incoming starts
>
> To fix it, check existing cap and only raise an error if the specific cap
> changed.
>
> Fixes: 82137e6c8c ("migration: enforce multifd and postcopy preempt to be set
> before incoming")
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/options.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Juraj Marcin <jmarcin@redhat.com>