Re: [PATCH 19/50] pnv/xive2: VC_ENDC_WATCH_SPEC regs should read back WATCH_FULL

[Caleb Schlossin]

Reviewed-by: Caleb Schlossin <calebs@linux.ibm.com>

On 5/11/25 10:10 PM, Nicholas Piggin wrote:
> Firmware expects to read back the WATCH_FULL bit from the VC_ENDC_WATCH_SPEC
> register, so don't clear it on read.
> 
> Don't bother clearing the reads-as-zero CONFLICT bit because it's masked
> at write already.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>  hw/intc/pnv_xive2.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
> index fcf5b2e75c..3c26cd6b77 100644
> --- a/hw/intc/pnv_xive2.c
> +++ b/hw/intc/pnv_xive2.c
> @@ -1329,7 +1329,6 @@ static uint64_t pnv_xive2_ic_vc_read(void *opaque, 
> hwaddr offset,
>      case VC_ENDC_WATCH2_SPEC:
>      case VC_ENDC_WATCH3_SPEC:
>          watch_engine = (offset - VC_ENDC_WATCH0_SPEC) >> 6;
> -        xive->vc_regs[reg] &= ~(VC_ENDC_WATCH_FULL | VC_ENDC_WATCH_CONFLICT);
>          pnv_xive2_endc_cache_watch_release(xive, watch_engine);
>          val = xive->vc_regs[reg];
>          break;