Re: [PATCH v3 12/22] target/ppc: Implement DCFFIXQQ

[Richard Henderson]

On 9/10/21 4:26 AM, Luis Pires wrote:
> +void helper_DCFFIXQQ(CPUPPCState *env, ppc_fprp_t *t, ppc_avr_t *b)
> +{
> +    struct PPC_DFP dfp;

Space here after the variable declaration would help.

> +    dfp_prepare_decimal128(&dfp, NULL, NULL, env);
> +    decNumberFromInt128(&dfp.t, (uint64_t)b->VsrD(1), (int64_t)b->VsrD(0));
> +    dfp_finalize_decimal128(&dfp);
> +    CFFIX_PPs(&dfp);
> +
> +    set_dfp128(t, &dfp.vt);
> +}

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~