Re: [PATCH v3 15/22] target/ppc: Implement DCTFIXQQ

[Richard Henderson]

On 9/10/21 4:26 AM, Luis Pires wrote:
> --- a/target/ppc/dfp_helper.c
> +++ b/target/ppc/dfp_helper.c
> @@ -51,6 +51,12 @@ static void set_dfp128(ppc_fprp_t *dfp, ppc_vsr_t *src)
>       dfp[1].VsrD(0) = src->VsrD(1);
>   }
>   
> +static void set_dfp128_to_avr(ppc_avr_t *dst, ppc_vsr_t *src)
> +{
> +    dst->VsrD(0) = src->VsrD(0);
> +    dst->VsrD(1) = src->VsrD(1);
> +}

Given that these two are typedef of one another, I would think this is unnecessary and you 
should just write *dst = *src.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~