|
| From: | BALATON Zoltan |
| Subject: | Re: [PATCH 06/10] target/ppc: Readability improvements in exception handlers |
| Date: | Wed, 14 Jun 2023 12:07:57 +0200 (CEST) |
On Wed, 14 Jun 2023, Nicholas Piggin wrote:
On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote:Improve readability by shortening some long comments, removing comments that state the obvious and dropping some empty lines so they don't distract when reading the code.Some changes are a matter of taste, but in the interest of having somebody do some spring cleaning of this code I don't want to nitpick it, so I won't :)
Thanks. I prefer functions to be less streched out vertically so more lines fit in a single screen. Ideally the whole function should be visible so it's easier to comprehend than having to scroll around but if there's something really bothering you I can consider changing that. But if you can accept this as it is then that's less work for me.
Regards, BALATON Zoltan
Acked-by: Nicholas Piggin <npiggin@gmail.com>Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- target/ppc/cpu.h | 1 + target/ppc/excp_helper.c | 180 +++++++-------------------------------- 2 files changed, 33 insertions(+), 148 deletions(-)
| [Prev in Thread] | Current Thread | [Next in Thread] |