[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] target/ppc: Readability improvements in exception hand
From: |
Nicholas Piggin |
Subject: |
Re: [PATCH 06/10] target/ppc: Readability improvements in exception handlers |
Date: |
Thu, 15 Jun 2023 10:59:48 +1000 |
On Wed Jun 14, 2023 at 8:07 PM AEST, BALATON Zoltan wrote:
> On Wed, 14 Jun 2023, Nicholas Piggin wrote:
> > On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote:
> >> Improve readability by shortening some long comments, removing
> >> comments that state the obvious and dropping some empty lines so they
> >> don't distract when reading the code.
> >
> > Some changes are a matter of taste, but in the interest of having
> > somebody do some spring cleaning of this code I don't want to nitpick
> > it, so I won't :)
>
> Thanks. I prefer functions to be less streched out vertically so more
> lines fit in a single screen. Ideally the whole function should be visible
> so it's easier to comprehend than having to scroll around but if there's
> something really bothering you I can consider changing that. But if you
> can accept this as it is then that's less work for me.
I don't mind vertical white space, actually like it. I don't like too
much stuff done per line.
Thanks,
Nick
- Re: [PATCH 03/10] target/ppc: Move common check in exception handlers to a function, (continued)
[PATCH 05/10] target/ppc: Change parameter of cpu_interrupt_exittb() to an env pointer, BALATON Zoltan, 2023/06/11
[PATCH 07/10] target/ppd: Remove unused define, BALATON Zoltan, 2023/06/11
[PATCH 06/10] target/ppc: Readability improvements in exception handlers, BALATON Zoltan, 2023/06/11
[PATCH 09/10] target/ppc: Simplify syscall exception handlers, BALATON Zoltan, 2023/06/11
[PATCH 10/10] target/ppc: Get CPUState in one step, BALATON Zoltan, 2023/06/11