Re: [PATCH 03/10] rust/irq: Add a helper to convert [InterruptSource] to [*mut IRQState]

[Zhao Liu]

On Fri, Feb 07, 2025 at 10:57:11AM +0100, Paolo Bonzini wrote:
> Date: Fri, 7 Feb 2025 10:57:11 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH 03/10] rust/irq: Add a helper to convert
>  [InterruptSource] to [*mut IRQState]
> 
> Il ven 7 feb 2025, 08:25 Zhao Liu <zhao1.liu@intel.com> ha scritto:
> 
> > Just to confirm, I check with `cargo +nightly clippy` but it doesn't
> > complain about this case. Should I switch to another version of clippy
> > when I do such check? (currently I'm using v0.1.63 clippy as well, to
> > match rustc.)
> >
> 
> I don't remember exactly how I noticed it—I am pretty sure it broke in CI
> though. Maybe the change to add rust_version hid it.
> 
> To answer your question, generally the idea is that we use the latest
> version of the developer tools (cargo, rustfmt, clippy). In particular old
> versions of cargo don't support retrieving clippy settings from Cargo.toml.

This one inspired me. I'm thinking that even though we deleted the
README of pl011, a gneral guide or doc section (at somewhere, e.g.,
docs/devel/style.rst or docs/devel/submitting-a-patch.rst) would be
helpful.

At least, that could remind contributor to check patches with latest
toolchain instead of letting the maintainer's CI smoking fail.

Thanks,
Zhao