[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/10] rust: add bindings for gpio_{in|out} initialization
|
From: |
Zhao Liu |
|
Subject: |
Re: [PATCH 04/10] rust: add bindings for gpio_{in|out} initialization |
|
Date: |
Sat, 8 Feb 2025 19:16:25 +0800 |
> Use the "let" so that it's caught at compile time.
Thanks! Fixed.
> There's a difference with origianl C version:
> >
> > In C side, qdev_get_gpio_in() family could accept a NULL handler, but
> > there's no such case in current QEMU:
> >
> > * qdev_get_gpio_in
> > * qdev_init_gpio_in_named
> > * qdev_init_gpio_in_named_with_opaque
> >
> > And from code logic view, creating an input GPIO line but doing nothing
> > on input, sounds also unusual.
> >
>
> Wouldn't it then crash in qemu_set_irq?
>
Yes! Thank you for the education.
Regards,
Zhao