[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference
|
From: |
David Hildenbrand |
|
Subject: |
Re: [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug() |
|
Date: |
Mon, 7 Jan 2019 10:02:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 04.01.19 15:33, Li Qiang wrote:
> What do you think of ‘g_assert_not_reached();’. For example:
>
>
>
> else {
>
> g_assert_not_reached();
>
> }
>
I agree, if thisever happens, it is a serious programming error, not an
error to report to the user. (after all, he did nothing wrong)
I'd prefer asserts.
--
Thanks,
David / dhildenb
- [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug(), Li Qiang, 2019/01/03
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug(), Cornelia Huck, 2019/01/04
- [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Li Qiang, 2019/01/04
- Re: [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(),
David Hildenbrand <=
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Cornelia Huck, 2019/01/07
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Peter Maydell, 2019/01/07
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Cornelia Huck, 2019/01/07
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Peter Maydell, 2019/01/07
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), Cornelia Huck, 2019/01/07
- Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug(), 李强, 2019/01/08
Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug(), Halil Pasic, 2019/01/04