Re: [qemu-s390x] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

[Peter Maydell]

On Mon, 7 Jan 2019 at 15:48, Cornelia Huck <address@hidden> wrote:
>
> On Fri, 4 Jan 2019 22:33:51 +0800
> Li Qiang <address@hidden> wrote:
>
> > What do you think of ‘g_assert_not_reached();’. For example:
> >
> > else {
> >      g_assert_not_reached();
> > }
>
> Sounds good. But please return anyway in the unplug case, so that the
> code is fine if asserts have been configured out.

Hopefully that won't cause the compiler to complain about
unreachable code :-)

thanks
-- PMM