Re: [qemu-s390x] [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support 
Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
77d73c7ed1 s390x/tcg: Implement VECTOR UNPACK *
ea715fef81 s390x/tcg: Implement VECTOR STORE WITH LENGTH
b124f9241e s390x/tcg: Implement VECTOR STORE MULTIPLE
b9879a4396 s390x/tcg: Implement VECTOR STORE ELEMENT
fba93be27b s390x/tcg: Implement VECTOR STORE
b603c0f392 s390x/tcg: Provide probe_write helper
99bb9a3b94 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
7882f2005e s390x/tcg: Implement VECTOR SELECT
0e6a1cd319 s390x/tcg: Implement VECTOR SCATTER ELEMENT
6f09c5514d s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
62ee114489 s390x/tcg: Implement VECTOR REPLICATE
39a1f68aea s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
8484c31053 s390x/tcg: Implement VECTOR PERMUTE
1ba7797b77 s390x/tcg: Implement VECTOR PACK *
bbf762520a s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
bf4c15ff5e s390x/tcg: Implement VECTOR LOAD WITH LENGTH
387f12ebf2 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
b32be93319 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
acce2e18b0 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
28dba86a8d s390x/tcg: Implement VECTOR LOAD MULTIPLE
861f401bd7 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
cbacc44de5 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
937df5685c s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
4dd1f64c18 s390x/tcg: Implement VECTOR LOAD ELEMENT
175cb562db s390x/tcg: Implement VECTOR LOAD AND REPLICATE
cb411cd963 s390x/tcg: Implement VECTOR LOAD
6c969cc824 s390x/tcg: Implement VECTOR GENERATE MASK
987032c5c6 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
227c308c9c s390x/tcg: Implement VECTOR GATHER ELEMENT
e377b691e0 s390x/tcg: Utilities for vector instruction helpers
5dbf75fdbe s390x/tcg: Check vector register instructions at central point
aa3ea725ba s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit aa3ea725ba88 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 5dbf75fdbeff (s390x/tcg: Check vector register 
instructions at central point)
3/32 Checking commit e377b691e0fa (s390x/tcg: Utilities for vector instruction 
helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 227c308c9c3c (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 987032c5c666 (s390x/tcg: Implement VECTOR GENERATE BYTE 
MASK)
6/32 Checking commit 6c969cc82417 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit cb411cd963d9 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 175cb562db07 (s390x/tcg: Implement VECTOR LOAD AND 
REPLICATE)
9/32 Checking commit 4dd1f64c186e (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 937df5685c48 (s390x/tcg: Implement VECTOR LOAD ELEMENT 
IMMEDIATE)
11/32 Checking commit cbacc44de5a4 (s390x/tcg: Implement VECTOR LOAD GR FROM VR 
ELEMENT)
12/32 Checking commit 861f401bd70a (s390x/tcg: Implement VECTOR LOAD LOGICAL 
ELEMENT AND ZERO)
13/32 Checking commit 28dba86a8d4a (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit acce2e18b0df (s390x/tcg: Implement VECTOR LOAD TO BLOCK 
BOUNDARY)
15/32 Checking commit b32be9331903 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT 
FROM GR)
16/32 Checking commit 387f12ebf2ca (s390x/tcg: Implement VECTOR LOAD VR FROM 
GRS DISJOINT)
17/32 Checking commit bf4c15ff5e3b (s390x/tcg: Implement VECTOR LOAD WITH 
LENGTH)
18/32 Checking commit bbf762520a38 (s390x/tcg: Implement VECTOR MERGE 
(HIGH|LOW))
19/32 Checking commit 1ba7797b7750 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              
\

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 8484c3105305 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, 
i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 39a1f68aea92 (s390x/tcg: Implement VECTOR PERMUTE 
DOUBLEWORD IMMEDIATE)
22/32 Checking commit 62ee1144895b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 6f09c5514dc9 (s390x/tcg: Implement VECTOR REPLICATE 
IMMEDIATE)
24/32 Checking commit 0e6a1cd319f2 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 7882f2005ef8 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 99bb9a3b94a5 (s390x/tcg: Implement VECTOR SIGN EXTEND TO 
DOUBLEWORD)
27/32 Checking commit b603c0f39216 (s390x/tcg: Provide probe_write helper)
28/32 Checking commit fba93be27bb9 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit b9879a4396c7 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit b124f9241e00 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit ea715fef81db (s390x/tcg: Implement VECTOR STORE WITH 
LENGTH)
32/32 Checking commit 77d73c7ed154 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden