Re: [qemu-s390x] [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support 
Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
5cae0d10fe s390x/tcg: Implement VECTOR UNPACK *
4f44aa5654 s390x/tcg: Implement VECTOR STORE WITH LENGTH
b9e54c6d14 s390x/tcg: Implement VECTOR STORE MULTIPLE
900959de1e s390x/tcg: Implement VECTOR STORE ELEMENT
a3c7ead3ed s390x/tcg: Implement VECTOR STORE
9d89ffa8dc s390x/tcg: Provide probe_write helper
d493cb908c s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
239f57c873 s390x/tcg: Implement VECTOR SELECT
06c2b37948 s390x/tcg: Implement VECTOR SCATTER ELEMENT
33913de262 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
be76b374bf s390x/tcg: Implement VECTOR REPLICATE
57dc6e4366 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
1afedf68d4 s390x/tcg: Implement VECTOR PERMUTE
24f88d3d03 s390x/tcg: Implement VECTOR PACK *
1fb1a87b0e s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
99c029e225 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
e7a54e791a s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
a4557b2aac s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
21d1736c92 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
e1f541f5c7 s390x/tcg: Implement VECTOR LOAD MULTIPLE
547df3f09f s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
9a077d74fb s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
7877e826b7 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
728adba863 s390x/tcg: Implement VECTOR LOAD ELEMENT
8098d3b6aa s390x/tcg: Implement VECTOR LOAD AND REPLICATE
2837793da8 s390x/tcg: Implement VECTOR LOAD
5b86bff39c s390x/tcg: Implement VECTOR GENERATE MASK
3201ce9097 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
e8553a2349 s390x/tcg: Implement VECTOR GATHER ELEMENT
f2c1c776e1 s390x/tcg: Utilities for vector instruction helpers
09866bc43c s390x/tcg: Check vector register instructions at central point
63a10c4c51 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 63a10c4c51c3 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 09866bc43c18 (s390x/tcg: Check vector register 
instructions at central point)
3/32 Checking commit f2c1c776e171 (s390x/tcg: Utilities for vector instruction 
helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit e8553a234922 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 3201ce90977e (s390x/tcg: Implement VECTOR GENERATE BYTE 
MASK)
6/32 Checking commit 5b86bff39c67 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 2837793da819 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 8098d3b6aad4 (s390x/tcg: Implement VECTOR LOAD AND 
REPLICATE)
9/32 Checking commit 728adba863fe (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 7877e826b7e4 (s390x/tcg: Implement VECTOR LOAD ELEMENT 
IMMEDIATE)
11/32 Checking commit 9a077d74fbcd (s390x/tcg: Implement VECTOR LOAD GR FROM VR 
ELEMENT)
12/32 Checking commit 547df3f09fa8 (s390x/tcg: Implement VECTOR LOAD LOGICAL 
ELEMENT AND ZERO)
13/32 Checking commit e1f541f5c780 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 21d1736c92ef (s390x/tcg: Implement VECTOR LOAD TO BLOCK 
BOUNDARY)
15/32 Checking commit a4557b2aac41 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT 
FROM GR)
16/32 Checking commit e7a54e791a48 (s390x/tcg: Implement VECTOR LOAD VR FROM 
GRS DISJOINT)
17/32 Checking commit 99c029e2250b (s390x/tcg: Implement VECTOR LOAD WITH 
LENGTH)
18/32 Checking commit 1fb1a87b0e57 (s390x/tcg: Implement VECTOR MERGE 
(HIGH|LOW))
19/32 Checking commit 24f88d3d0314 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              
\

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 1afedf68d4e0 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, 
i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 57dc6e436649 (s390x/tcg: Implement VECTOR PERMUTE 
DOUBLEWORD IMMEDIATE)
22/32 Checking commit be76b374bf5b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 33913de262e7 (s390x/tcg: Implement VECTOR REPLICATE 
IMMEDIATE)
24/32 Checking commit 06c2b37948d6 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 239f57c873ec (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit d493cb908c76 (s390x/tcg: Implement VECTOR SIGN EXTEND TO 
DOUBLEWORD)
27/32 Checking commit 9d89ffa8dc4f (s390x/tcg: Provide probe_write helper)
28/32 Checking commit a3c7ead3edb3 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 900959de1e8d (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit b9e54c6d1464 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 4f44aa5654a9 (s390x/tcg: Implement VECTOR STORE WITH 
LENGTH)
32/32 Checking commit 5cae0d10fe9e (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden