Re: [qemu-s390x] [PATCH v4 10/15] s390-bios: Support for running format-0/1 channel programs

[Cornelia Huck]

On Mon, 11 Mar 2019 11:21:28 -0400
"Jason J. Herne" <address@hidden> wrote:

> Introduce a library function for executing format-0 and format-1
> channel programs and waiting for their completion before continuing
> execution.
> 
> Add cu_type() to channel io library. This will be used to query control
> unit type which is used to determine if we are booting a virtio device or a
> real dasd device.
> 
> Signed-off-by: Jason J. Herne <address@hidden>
> ---
>  pc-bios/s390-ccw/cio.c      | 144 
> ++++++++++++++++++++++++++++++++++++++++++++
>  pc-bios/s390-ccw/cio.h      | 130 ++++++++++++++++++++++++++++++++++++++-
>  pc-bios/s390-ccw/s390-ccw.h |   1 +
>  pc-bios/s390-ccw/start.S    |  29 +++++++++
>  4 files changed, 301 insertions(+), 3 deletions(-)

(...)

> +    rc = ssch(schid, &orb);
> +    if (rc == 1 || rc == 2) {
> +        /* Subchannel status pending or busy. Eat status and ask for retry. 
> */
> +        tsch(schid, irb);

Not really needed for cc 2; but should not hurt, either.

> +        return -1;
> +    }

(...)

Reviewed-by: Cornelia Huck <address@hidden>