Re: [qemu-s390x] [PATCH v4 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

[Cornelia Huck]

On Tue, 12 Mar 2019 10:39:04 -0400
"Jason J. Herne" <address@hidden> wrote:

> On 3/12/19 6:38 AM, Cornelia Huck wrote:
> > On Mon, 11 Mar 2019 11:21:19 -0400
> > "Jason J. Herne" <address@hidden> wrote:
> >   
> >> Add bootindex property and iplb data for vfio-ccw devices. This allows us 
> >> to
> >> forward boot information into the bios for vfio-ccw devices.
> >>
> >> Refactor s390_get_ccw_device() to return device type. This prevents us from
> >> having to use messy casting logic in several places.
> >>
> >> Signed-off-by: Jason J. Herne <address@hidden>
> >> Acked-by: Halil Pasic <address@hidden>
> >> ---
> >>   MAINTAINERS                 |  1 +
> >>   hw/s390x/ipl.c              | 61 
> >> ++++++++++++++++++++++++++++++++++-----------
> >>   hw/s390x/s390-ccw.c         |  9 +++++++
> >>   hw/vfio/ccw.c               |  2 +-
> >>   include/hw/s390x/s390-ccw.h |  1 +
> >>   include/hw/s390x/vfio-ccw.h | 28 +++++++++++++++++++++
> >>   6 files changed, 86 insertions(+), 16 deletions(-)
> >>   create mode 100644 include/hw/s390x/vfio-ccw.h  
> > 
> > Reviewed-by: Cornelia Huck <address@hidden>
> > 
> >   
> 
> Connie & Thomas,
> 
> We're only missing R-b/Ack's on 11, 12 and 13. It looks like this is getting 
> quite close 
> to ready. Thanks for all your help making this patch set better than it was 
> when I 
> submitted v1. I appreciate your enthusiasm and willingness to provide 
> feedback. :-)
> 

The remaining patches are on my todo list... but this is too late for
4.0 anyway (softfreeze is today). (FWIW, there is probably nothing
major left, but I'll leave the decision to the boot code maintainers,
i.e. Christian and Thomas.)