Re: [qemu-s390x] [Qemu-devel] [PATCH v1 39/41] s390x/tcg: Implement VECTOR SUM ACROSS QUADWORD

[Richard Henderson]

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +    read_vec_element_i64(suml, get_field(s->fields, v3), max_idx, es);
> +    for (idx = 0; idx <= max_idx; idx++) {
> +        read_vec_element_i64(tmpl, get_field(s->fields, v2), idx, es);
> +        tcg_gen_add2_i64(suml, sumh, suml, sumh, tmpl, zero);
> +    }
> +    write_vec_element_i64(sumh, get_field(s->fields, v1), 0, ES_64);
> +    write_vec_element_i64(suml, get_field(s->fields, v1), 1, ES_64);

It's a long way around for ES_32, as there will never be overflow into bit 65.
 But I guess it's not wrong.

Reviewed-by: Richard Henderson <address@hidden>


r~