[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro
From: |
Philippe Mathieu-Daudé |
Subject: |
[qemu-s390x] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev |
Date: |
Tue, 28 May 2019 18:40:16 +0200 |
Rather than looking inside the definition of a DeviceState with
"s->qdev", use the QOM prefered style: "DEVICE(s)".
This patch was generated using the following Coccinelle script
(with a bit of manual fix-up, removing an extra space to please
checkpatch.pl):
// Use DEVICE() macros to access DeviceState.qdev
@use_device_macro_to_access_qdev@
expression obj;
identifier dev;
@@
-&obj->dev.qdev
+DEVICE(obj)
Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/audio/ac97.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index 2265622d44..a4e8d99e77 100644
--- a/hw/audio/ac97.c
+++ b/hw/audio/ac97.c
@@ -1388,7 +1388,7 @@ static void ac97_realize(PCIDevice *dev, Error **errp)
pci_register_bar (&s->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io_nam);
pci_register_bar (&s->dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &s->io_nabm);
AUD_register_card ("ac97", &s->card);
- ac97_on_reset (&s->dev.qdev);
+ ac97_on_reset(DEVICE(s));
}
static void ac97_exit(PCIDevice *dev)
--
2.20.1
- [qemu-s390x] [PATCH v2 00/10] qom: Use BUS()/DEVICE() macros instead of looking inside definitions, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev,
Philippe Mathieu-Daudé <=
- [qemu-s390x] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 10/10] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 05/10] hw/sd: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 07/10] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28