[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM B
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus |
Date: |
Tue, 28 May 2019 19:00:01 +0200 |
On Tue, 28 May 2019 18:40:14 +0200
Philippe Mathieu-Daudé <address@hidden> wrote:
> Rather than looking inside the definition of a BusState with "s->bus.qbus",
> use the QOM prefered style: "BUS(&s->bus)".
>
> This patch was generated using the following Coccinelle script:
>
> // Use BUS() macros to access BusState.qbus
> @use_bus_macro_to_access_qbus@
> expression obj;
> identifier bus;
> @@
> -&obj->bus.qbus
> +BUS(&obj->bus)
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/s390x/event-facility.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
(I assume this will go through the trivial tree?)
- [qemu-s390x] [PATCH v2 00/10] qom: Use BUS()/DEVICE() macros instead of looking inside definitions, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- Re: [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus,
Cornelia Huck <=
- [qemu-s390x] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 10/10] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 05/10] hw/sd: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 07/10] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28