[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode
From: |
David Hildenbrand |
Subject: |
[PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode |
Date: |
Mon, 23 Sep 2019 10:06:53 +0200 |
Triggered by a review comment from Richard, also MVCOS has a 32-bit
length in 24/31-bit addressing mode. Add a new helper.
Rename wrap_length() to wrap_length31().
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 20e1ac0ea9..320e9ee65c 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -528,7 +528,15 @@ static inline void set_address(CPUS390XState *env, int
reg, uint64_t address)
}
}
-static inline uint64_t wrap_length(CPUS390XState *env, uint64_t length)
+static inline uint64_t wrap_length32(CPUS390XState *env, uint64_t length)
+{
+ if (!(env->psw.mask & PSW_MASK_64)) {
+ return (uint32_t)length;
+ }
+ return length;
+}
+
+static inline uint64_t wrap_length31(CPUS390XState *env, uint64_t length)
{
if (!(env->psw.mask & PSW_MASK_64)) {
/* 24-Bit and 31-Bit mode */
@@ -539,7 +547,7 @@ static inline uint64_t wrap_length(CPUS390XState *env,
uint64_t length)
static inline uint64_t get_length(CPUS390XState *env, int reg)
{
- return wrap_length(env, env->regs[reg]);
+ return wrap_length31(env, env->regs[reg]);
}
static inline void set_length(CPUS390XState *env, int reg, uint64_t length)
@@ -2378,7 +2386,7 @@ uint32_t HELPER(mvcos)(CPUS390XState *env, uint64_t dest,
uint64_t src,
s390_program_interrupt(env, PGM_PRIVILEGED, 6, ra);
}
- len = wrap_length(env, len);
+ len = wrap_length32(env, len);
if (len > 4096) {
cc = 3;
len = 4096;
--
2.21.0
- [PULL 01/30] s390x/tcg: Reset exception_index to -1 instead of 0, (continued)
- [PULL 01/30] s390x/tcg: Reset exception_index to -1 instead of 0, David Hildenbrand, 2019/09/23
- [PULL 02/30] s390x/tcg: MVCL: Zero out unused bits of address, David Hildenbrand, 2019/09/23
- [PULL 03/30] s390x/tcg: MVCL: Detect destructive overlaps, David Hildenbrand, 2019/09/23
- [PULL 04/30] s390x/tcg: MVCL: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 05/30] s390x/tcg: MVC: Increment the length once, David Hildenbrand, 2019/09/23
- [PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap(), David Hildenbrand, 2019/09/23
- [PULL 07/30] s390x/tcg: MVPG: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses, David Hildenbrand, 2019/09/23
- [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 10/30] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/23
- [PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode,
David Hildenbrand <=
- [PULL 12/30] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/23
- [PULL 13/30] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 14/30] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/23
- [PULL 15/30] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/23
- [PULL 16/30] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/23
- [PULL 18/30] s390x/tcg: MVCS/MVCP: Use access_memmove(), David Hildenbrand, 2019/09/23
- [PULL 17/30] s390x/tcg: Fault-safe memmove, David Hildenbrand, 2019/09/23
- [PULL 19/30] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, David Hildenbrand, 2019/09/23
- [PULL 20/30] s390x/tcg: MVCLU: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 21/30] s390x/tcg: OC: Fault-safe handling, David Hildenbrand, 2019/09/23