[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 19/30] s390x/tcg: MVC: Fault-safe handling on destructive overlaps
From: |
David Hildenbrand |
Subject: |
[PULL 19/30] s390x/tcg: MVC: Fault-safe handling on destructive overlaps |
Date: |
Mon, 23 Sep 2019 10:07:01 +0200 |
The last remaining bit for MVC is handling destructive overlaps in a
fault-safe way.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 04c4228f13..aed53a37da 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -438,8 +438,9 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t
l, uint64_t dest,
access_memmove(env, &desta, &srca, ra);
} else {
for (i = 0; i < l; i++) {
- uint8_t x = cpu_ldub_data_ra(env, src + i, ra);
- cpu_stb_data_ra(env, dest + i, x, ra);
+ uint8_t byte = access_get_byte(env, &srca, i, ra);
+
+ access_set_byte(env, &desta, i, byte, ra);
}
}
--
2.21.0
- [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, (continued)
- [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 10/30] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/23
- [PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/23
- [PULL 12/30] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/23
- [PULL 13/30] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 14/30] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/23
- [PULL 15/30] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/23
- [PULL 16/30] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/23
- [PULL 18/30] s390x/tcg: MVCS/MVCP: Use access_memmove(), David Hildenbrand, 2019/09/23
- [PULL 17/30] s390x/tcg: Fault-safe memmove, David Hildenbrand, 2019/09/23
- [PULL 19/30] s390x/tcg: MVC: Fault-safe handling on destructive overlaps,
David Hildenbrand <=
- [PULL 20/30] s390x/tcg: MVCLU: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 21/30] s390x/tcg: OC: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 22/30] s390x/tcg: XC: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 23/30] s390x/tcg: NC: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 24/30] s390x/tcg: MVCIN: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 25/30] s390x/tcg: MVN: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 26/30] s390x/tcg: MVZ: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 27/30] s390x/tcg: MVST: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 28/30] s390x/tcg: MVO: Fault-safe handling, David Hildenbrand, 2019/09/23
- [PULL 29/30] tests/tcg: target/s390x: Test MVO, David Hildenbrand, 2019/09/23