Re: [PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA

[David Hildenbrand]

On 05.03.20 10:55, Janosch Frank wrote:
> On 3/4/20 7:56 PM, David Hildenbrand wrote:
>> On 04.03.20 12:42, Janosch Frank wrote:
>>> For protected guests, we need to put the IO emulation results into the
>>> SIDA, so SIE will write them into the guest at the next entry.
>>>
>>
>> [...]
>>
>>>  
>>>      if (ioinst_disassemble_sch_ident(reg1, &m, &cssid, &ssid, &schid)) {
>>> +        if (env->pv) {
>>> +            return;
>>> +        }
>>
>> Can you elaborate why we don't have to do anything here? I can
>> understand why we don't/cannot probe for writes. But what about the
>> PGM_OPERAND?
> 
> CSSID and the schid one check are done by the Ultravisor/SIE
> 

So can we even reach this path?


-- 
Thanks,

David / dhildenb