Re: [PATCH v6 16/18] s390x: Add unpack facility feature to GA1

[David Hildenbrand]

On 06.03.20 11:14, Janosch Frank wrote:
> On 3/4/20 12:42 PM, Janosch Frank wrote:
>> From: Christian Borntraeger <address@hidden>
>>
>> The unpack facility is an indication that diagnose 308 subcodes 8-10
>> are available to the guest. That means, that the guest can put itself
>> into protected mode.
>>
>> Once it is in protected mode, the hardware stops any attempt of VM
>> introspection by the hypervisor.
>>
>> Some features are currently not supported in protected mode:
>>      * Passthrough devices
>>      * Migration
>>      * Huge page backings
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
> 
> This one will be the first patch (after sync) and will also get the
> DEF_FEAT definition, so I can use it in the diag 308 8-10 patch

You should still enable the whole machinery only after everything has
been implemented. Moving the feature is fine.


-- 
Thanks,

David / dhildenb