[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW |
|
Date: |
Fri, 13 Mar 2020 15:22:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 13.03.20 15:21, Janosch Frank wrote:
[..]
>>> + } else {
>>> + s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu);
>>> + }
>>> s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
>>> }
>>> #endif
>>
>> I don't understand why you set the state to S390_CPU_STATE_LOAD and
>> then immediately afterwards to S390_CPU_STATE_OPERATING, especially
>> considering that both do the same
>>
>
> Have a look at the specs, wee need to set the load state before setting
> the cpu to operating.
>
> I can add a comment to make it clearer if you want.
Yes please. I stumbled over this as well before I read the specs.
Re: [PATCH v9 02/15] s390x: protvirt: Support unpack facility, Claudio Imbrenda, 2020/03/13
[PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW, Janosch Frank, 2020/03/11
[PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD, Janosch Frank, 2020/03/11
Re: [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD, Claudio Imbrenda, 2020/03/13
[PATCH v9 15/15] s390x: Add unpack facility feature to GA1, Janosch Frank, 2020/03/11