Re: [PATCH 0/8] pc-bios: s390x: Cleanup part 1

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/8] pc-bios: s390x: Cleanup part 1
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
631f5fb pc-bios: s390x: Make u32 ptr check explicit
31a77a2 pc-bios: s390x: Replace 0x00 with 0x0 or 0
e7c3314 pc-bios: s390x: Use ebcdic2ascii table
67bf6cc pc-bios: s390x: Move panic() into header and add infinite loop
0430d47 pc-bios: s390x: Use PSW masks where possible
5dc5f58 pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
49da8ad pc-bios: s390x: Get rid of magic offsets into the lowcore
61a8ff1 pc-bios: s390x: Consolidate timing functions into time.h

=== OUTPUT BEGIN ===
1/8 Checking commit 61a8ff1495d4 (pc-bios: s390x: Consolidate timing functions 
into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#102: 
new file mode 100644

total: 0 errors, 1 warnings, 167 lines checked

Patch 1/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 49da8ad037ea (pc-bios: s390x: Get rid of magic offsets into 
the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#29: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: code indent should never use tabs
#30: FILE: pc-bios/s390-ccw/cio.h:128:
+^I    __u16:4;$

ERROR: spaces required around that ':' (ctx:VxV)
#31: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#32: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#33: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 2/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/8 Checking commit 5dc5f5840149 (pc-bios: s390x: Rename and use PSW_MASK_ZMODE 
constant)
4/8 Checking commit 0430d47d5125 (pc-bios: s390x: Use PSW masks where possible)
5/8 Checking commit 67bf6cc8c901 (pc-bios: s390x: Move panic() into header and 
add infinite loop)
6/8 Checking commit e7c33142a550 (pc-bios: s390x: Use ebcdic2ascii table)
7/8 Checking commit 31a77a28b0f3 (pc-bios: s390x: Replace 0x00 with 0x0 or 0)
8/8 Checking commit 631f5fb35427 (pc-bios: s390x: Make u32 ptr check explicit)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden