[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile.hw: avoid overly large

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile.hw: avoid overly large 'make clean' rm command
Date: Fri, 22 Jun 2012 10:04:20 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jun 19, 2012 at 03:55:38PM +0100, Peter Maydell wrote:
> Avoid 'make clean' producing an 'rm' command which has a lot
> of duplicate 'hw//*.o' arguments, by using $(sort $(dir ..))
> rather than $(dir $(sort ..)) so Make's sort function will
> remove the duplicates for us. We can also remove the double
> '//' safely because $(dir ..) is guaranteed to return a string
> ending in '/'.
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Mostly cosmetic, although I guess there's a faint chance that expanding
> all those hw/*.o would hit the command line argument buffer limit...
>  Makefile.hw |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]