[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak
From: |
Gabriel Kerneis |
Subject: |
Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak |
Date: |
Wed, 11 Sep 2013 15:42:31 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 11, 2013 at 04:01:50PM +0200, Paolo Bonzini wrote:
> > ./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'"
>
> Where does the shell read config-host.mak? Make does not need the quotes.
I might have been confused about the shell vs. make interpreting the
string, but I am positive that without the patch, the following fails:
mkdir bin/test
cd bin/test
../../configure \
--extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))' -w"
make tests/test-coroutine
touch ../../configure
make tests/test-coroutine
with the following error message:
config-host.mak is out-of-date, running configure
sh: 1: Syntax error: "(" unexpected
make: *** [config-host.mak] Error 2
My patch fixes this issue.
--
Gabriel
- [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak,
Gabriel Kerneis <=
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Eric Blake, 2013/09/11