[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Fix build for less common build directories n
Re: [Qemu-trivial] [PATCH] Fix build for less common build directories names
Fri, 14 Oct 2016 12:17:26 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
On 14/10/2016 11:53, Stefan Hajnoczi wrote:
> > Why does it need to care about the build directory name at all?
> > Ideally builds should be entirely deterministically reproducible
> > whatever the path to the source or build directory names is...
> It's trying to construct the relative path from the source directory to
> a trace-events file (inside the source directory). This is used so that
> block/trace-event macros have BLOCK in their name while net/trace-events
> have NET, etc.
But Stefan (Weil) is right, it's actually including the path to the
build directory if you're building with objdir!=srcdir. It should not