[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix build for less common build
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix build for less common build directories names
Sun, 16 Oct 2016 14:36:31 +0100
On Fri, Oct 14, 2016 at 10:05:18PM +0200, Stefan Weil wrote:
> On 10/14/16 12:01, Stefan Hajnoczi wrote:
> > dirname should only contain QEMU source tree subdirectory paths (e.g.
> > hw/net). How did you get a comma in there?
> > I tried an out-of-tree build in a directory called 'a,b' but it doesn't
> > trigger the issue.
> > I'd like to understand how to reproduce the problem in case I missed
> > something.
> > Stefan
> I can reproduce it like this from the QEMU base directory:
> $ mkdir a,b
> $ cd a,b
> $ ../configure
> $ make
> make: *** [trace/generated-tracers.o] Error 1
> $ head trace/generated-tracers.h
> /* This file is autogenerated by tracetool, do not edit. */
> #ifndef TRACE_A,B_GENERATED_TRACERS_H
> #define TRACE_A,B_GENERATED_TRACERS_H
Interesting! I missed it because my a,b directory was not inside the
Description: PGP signature