[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() |
Date: |
Mon, 9 Mar 2020 13:21:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
> size = 4;
> ^ ~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: Paolo Bonzini <address@hidden>
> Cc:Fam Zheng <address@hidden>
> ---
> hw/scsi/esp-pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index d5a1f9e017..2e6cc07d4e 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
> val <<= shift;
> val |= current & ~(mask << shift);
> addr &= ~3;
> - size = 4;
> }
perhaps a "g_assert(size >= 4)" instead would be cleaner to mute the
warning?
I think it's a good point to update the size if in the future the code
below is modified to use size.
Thanks,
Laurent
- RE: [PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements, (continued)
[PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open(), Chen Qun, 2020/03/02
[PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Chen Qun, 2020/03/02
[PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(), Chen Qun, 2020/03/02
- Re: [PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(),
Laurent Vivier <=
[PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Chen Qun, 2020/03/02
[PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), Chen Qun, 2020/03/02
[PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), Chen Qun, 2020/03/02
[PATCH v3 01/12] block/stream: Remove redundant statement in stream_run(), Chen Qun, 2020/03/02