[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/12] display/exynos4210_fimd: Remove redundant statement
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 07/12] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() |
Date: |
Mon, 9 Mar 2020 13:54:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is
> never read
> is_dirty = false;
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: Igor Mitsyanko <address@hidden>
> Cc: Peter Maydell <address@hidden>
> ---
> hw/display/exynos4210_fimd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c
> index c1071ecd46..05d3265b76 100644
> --- a/hw/display/exynos4210_fimd.c
> +++ b/hw/display/exynos4210_fimd.c
> @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque)
> }
> host_fb_addr += inc_size;
> fb_line_addr += inc_size;
> - is_dirty = false;
> }
> g_free(snap);
> blend = true;
>
Reviewed-by: Laurent Vivier <address@hidden>
[PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Chen Qun, 2020/03/02