[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
From: |
AlexChen |
Subject: |
Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket() |
Date: |
Thu, 5 Nov 2020 14:53:48 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 |
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>
> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
> perror("failed to connect");
> + close(fd);
> return false;
> }
>
- Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket(),
AlexChen <=