[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] plugins: Fix two resource leaks in connect_socket()
From: |
AlexChen |
Subject: |
Re: [PATCH 2/2] plugins: Fix two resource leaks in connect_socket() |
Date: |
Thu, 5 Nov 2020 14:54:17 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 |
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Either accept() fails or exits normally, we need to close the fd.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index 319bd44b83..5aad50869d 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
> socket_fd = accept(fd, NULL, NULL);
> if (socket_fd < 0 && errno != EINTR) {
> perror("accept socket");
> + close(fd);
> return false;
> }
>
> qemu_plugin_outs("setup_socket::ready\n");
>
> + close(fd);
> return true;
> }
>
- Re: [PATCH 2/2] plugins: Fix two resource leaks in connect_socket(),
AlexChen <=