[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket() |
|
Date: |
Fri, 6 Nov 2020 07:17:12 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/5/20 7:59 PM, AlexChen wrote:
> Close the fd when the connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
Your From: line ("AlexChen") is spelled differently than your S-o-b:
line ("Alex Chen"). While this is not fatal to the patch, it is
confusing, so you may want to update your git settings to produce mail
spelled in the same manner as the S-o-b.
Also, although you did manage to send a 0/2 letter, you did not thread
things:
0/2 Message-ID: <5FA4AE0B.1000007@huawei.com>
1/2 Message-ID: Message-ID: <5FA4AE11.6060701@huawei.com>, but no
In-Reply-To: or References: headers, which means it is a new top-level
thread. You may want to figure out why your mail setup is not
preserving threading.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org