Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()

[AlexChen]

On 2020/11/6 21:17, Eric Blake wrote:
> On 11/5/20 7:59 PM, AlexChen wrote:
>> Close the fd when the connect() fails.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Alex Chen <alex.chen@huawei.com>
> 
> Your From: line ("AlexChen") is spelled differently than your S-o-b:
> line ("Alex Chen").  While this is not fatal to the patch, it is
> confusing, so you may want to update your git settings to produce mail
> spelled in the same manner as the S-o-b.
> 

Hi Eric,

Thanks for you suggestion, I will modify the user.name of git to "Alex Chen".

> Also, although you did manage to send a 0/2 letter, you did not thread
> things:
> 0/2 Message-ID: <5FA4AE0B.1000007@huawei.com>
> 1/2 Message-ID: Message-ID: <5FA4AE11.6060701@huawei.com>, but no
> In-Reply-To: or References: headers, which means it is a new top-level
> thread.  You may want to figure out why your mail setup is not
> preserving threading.
> 

This may be my email settings is wrong, I try to modify the setting and send a 
patch v3.

Thanks,
Alex