[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/7] silence the compiler warnings
From: |
Chen Qun |
Subject: |
[PATCH v3 0/7] silence the compiler warnings |
Date: |
Mon, 16 Nov 2020 10:48:03 +0800 |
Hi folks,
This series fix some "fall through" warnings reported by GCC_9.3. They've
been
reviewed for a long time. Some of these patchs may be important for QEMU 5.2.
Such as the Patch6 miss a break statement. Others only add "fall through"
comments and may not have a negative impact for QEMU 5.2.
Thanks,
Chen Qun
Since v2:
- Patch3:Add Richard Henderson、Philippe Mathieu-Daudé and Thomas Huth reviewed
tag.
- Patch4: Laurent pull it to master, remove it.
- Patch6->Patch5: Add Richard Henderson and Philippe Mathieu-Daudé reviewed tag.
- Patch7->Patch6: Add Thomas Huth reviewed tag and David Gibson acked tag.
- Patch8->Patch7: Tweak LOG_UNIMP message base on Thomas Huth comment;
Add Philippe Mathieu-Daudé and Thomas Huth reviewed tag; Add David Gibson
acked tag.
Since v1:
- Patch1: Add comments to explain the two case of fall through.
Addressed Richard Henderson and Thomas Huth review comment.
- Patch2: Addressed Peter Maydell review comment.
- Patch3: Add QEMU_NORETURN to cpu_exit_tb_from_sighandler() function to
avoid the compiler warnings.
- Patch4: Addressed Thomas Huth review comment.
- Patch5: Addressed Artyom Tarasenko and Philippe Mathieu-Daudé review
comment.
- Patch6: Combine the /* fall through */ to the preceding comments.
Addressed Artyom Tarasenko review comment.
- Patch7: Add a "break" statement here instead of /* fall through */
comments.
- Patch8: Replace the TODO by a LOG_UNIMP call and add break statement
- Patch9: Discard this patch since a patch already exists for fix this
issue(https://lore.kernel.org/qemu-devel/20200711154242.41222-1-ysato@users)
Chen Qun (7):
target/i386: silence the compiler warnings in gen_shiftd_rm_T1
hw/intc/arm_gicv3_kvm: silence the compiler warnings
accel/tcg/user-exec: silence the compiler warnings
target/sparc/translate: silence the compiler warnings
target/sparc/win_helper: silence the compiler warnings
ppc: Add a missing break for PPC6xx_INPUT_TBEN
target/ppc: replaced the TODO with LOG_UNIMP and add break for silence
warnings
accel/tcg/user-exec.c | 3 ++-
hw/intc/arm_gicv3_kvm.c | 8 ++++++++
hw/ppc/ppc.c | 1 +
target/i386/translate.c | 7 +++++--
target/ppc/mmu_helper.c | 5 +++--
target/sparc/translate.c | 2 +-
target/sparc/win_helper.c | 2 +-
7 files changed, 21 insertions(+), 7 deletions(-)
--
2.27.0
- [PATCH v3 0/7] silence the compiler warnings,
Chen Qun <=
- [PATCH v3 1/7] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/11/15
- [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN, Chen Qun, 2020/11/15
- [PATCH v3 4/7] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings, Chen Qun, 2020/11/15