[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN
From: |
Chen Qun |
Subject: |
[PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN |
Date: |
Mon, 16 Nov 2020 10:48:09 +0800 |
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’:
hw/ppc/ppc.c:118:16: warning: this statement may fall through
[-Wimplicit-fallthrough=]
118 | if (level) {
| ^
hw/ppc/ppc.c:123:9: note: here
123 | case PPC6xx_INPUT_INT:
| ^~~~
According to the discussion, a break statement needs to be added here.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
---
v1->v2: Add a "break" statement here instead of /* fall through */ comments
(Base on Thomas's and David review).
Cc: Thomas Huth <thuth@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/ppc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c
index 4a11fb1640..1b98272076 100644
--- a/hw/ppc/ppc.c
+++ b/hw/ppc/ppc.c
@@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level)
} else {
cpu_ppc_tb_stop(env);
}
+ break;
case PPC6xx_INPUT_INT:
/* Level sensitive - active high */
LOG_IRQ("%s: set the external IRQ state to %d\n",
--
2.27.0
- [PATCH v3 0/7] silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 1/7] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/11/15
- [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN,
Chen Qun <=
- [PATCH v3 4/7] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings, Chen Qun, 2020/11/15
- [PATCH v3 5/7] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 2/7] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Chen Qun, 2020/11/15