Re: [Quilt-dev] Versioned .pc

[Andreas Gruenbacher]

Hi Martin,

thanks for working on this. I've changed a few more things, then committed 
this to the CVS. There is an unrelated fix in the CVS now that has to do with 
how file creations/removals end up in patches (quilt wasn't quite compliant; 
I noticed when I accidentally ran a file creation patch twice and the file 
ended up containing the same data twice). We're at version 0.34 now; 
hopefully I didn't introduce any regressions.

On Wednesday 09 June 2004 09:17, Martin Quinson wrote:
> Hello,
>
> here is a modified version of your patch. Here are the changes introduced
> (over your version):
>
>  - It works here (TM). Yours failed because of a space in $proper_name in
>    one of my trees.

Spaces in patch names are not supposed to work. There are surely many places 
all across the code where patch names are expected to be a single word. It's 
surely possible to fix this up, but I don't think we really need this 
feature. Parsing of series files also doesn't allow for spaces in patch 
names.

>  - upgrade is not automatic, and a new 'upgrade' command is introduced.

Very good. I've set the version to 2 now in case we later find other 
incompatibilities with historic versions that we need to fix up.

>  - It tests also for too advanced version, and croaks about the
> impossibility of upward compatibility when it detects some.

Good.

>  - It does more output, and more friendly one (but there is an "echo -n"
>    that you might not like).

I changed that a little; hope you don't mind.

>  - The messages are translated to french.

Some strings changed in the merge as well -- could you please fix up the 
French translation? Thanks a lot.

> I doubt of this chunk, but leaved it where it was:
>
>  add_to_db()
>  {
> +       if ! [ -e $QUILT_PC/.version ]
> +       then
> +               echo $DB_VERSION > $QUILT_PC/.version
> +       fi
> +
>         echo $1 >> $DB
>  }
> <<<<<<<<<

That was a quick hack so that all tree manipulations will also result in 
a .version file. I'm now doing this only for the push and new commands, which 
should suffice.

> If you like it and commit it, I'd say this change is enough to tag the 0.34
> version (I really need this feature for the debian package ;).

I think you should be fine with CVS head now.

Cheers,
-- 
Andreas Gruenbacher <address@hidden>
SUSE Labs, SUSE LINUX AG