Re: [Quilt-dev] Term::ReadKey in test/run

[Jean Delvare]

Hi John,

> > --- quilt.orig/test/run Thu Feb 10 11:59:24 2005
> > +++ quilt/test/run      Tue Sep  6 11:50:53 2005
> > @@ -13,7 +13,6 @@
> >  use FileHandle;
> >  use Getopt::Std;
> >  use POSIX qw(isatty setuid);
> > -use Term::ReadKey;
> >  use vars qw($opt_l $opt_v);
> >
> >  no warnings qw(taint);
> > @@ -33,7 +32,7 @@
> >  my $prog_line;
> >  my ($tests, $failed) = (0,0);
> >  my $lineno;
> > -my $width=((GetTerminalSize)[0] >> 1);
> > +my $width=(($ENV{COLUMNS} || 80) >> 1);
> >
> >  for (;;) {
> >    my $line = <>; $lineno++;
>
> We appear to have forgotten about this one.  Your suggestion is simple
> and effective; it has my vote.

I was under the impression that Andreas didn't like it, which is why I
never committed it to CVS. I still have it applied locally.

IIRC, Andreas had something more complex in mind. I don't think the
additional work and maintenance effort is worth the benefit, but I also
seem to recall that Andreas is using the same script elsewhere and did
not want to have to maintain several copies separately. Thus I will not
apply this patch without an explicit approval from Andreas.

Thanks,
--
Jean Delvare