Re: [Quilt-dev] [patch 26/26] Rewrite discussion of QUILT_COLORS configuration variable.

[G. Branden Robinson]

Hi Jean,

At 2022-07-04T14:18:11+0200, Jean Delvare wrote:
> Hi Branden,
> 
> On Tue, 2 Oct 2018 03:34:22 -0400, G. Branden Robinson wrote:
> > Thanks for your review of these patches; I think we had a good meeting
> > of the minds.  Just needs that final push.
> 
> It's been a while, I know.

Indeed it has!

> As part of SUSE's Hack Week 21, I decided to exhume this old patch
> series of yours which has been in the back of my mind for the last 4
> years. I could never get over the idea that all the work we both put
> into it would go to waste.

I agree.  I have not forgotten about this; I simply had a couple of
international moves, changed jobs, and got even more deeply engrossed in
groff development.  :)

> The project's page is here:
> https://hackweek.opensuse.org/21/projects/update-quilts-manual-page
> 
> What I've done so far:
> * Rebase the whole series on top of the current version of quilt's
>   manual page. There were lots of context changes due to additions and
>   fixes that were made to the manual page over the last 4 years.
> * Update individual patches to propagate the changes to the added
>   paragraphs, so that the changes are consistent and complete for the
>   current version of the manual page.

Sounds good!

> Now I'm reaching the next step of the process, which is to go through
> my own review and apply the suggested corrections where applicable.
> Unfortunately, I see that there were a lot of questions of mine which
> were left unanswered. As I do not have your deep knowledge of the roff
> language, macros and good practices, I don't feel good enforcing my
> views.

A bit of good news is that I've managed to learn a few more things over
the past four years.  So I may now have ideas about how to solve certain
problems that I didn't back then.

> On the other hand, there are a few changes you proposed which clearly
> did not make sense or were confusing, so it also does not feel right
> to apply your patches without cleaning them up first.

Perfectly fair.

> Therefore, if you are still around, still have some interest in the
> project, and have a few spare cycles you could allocate for this task,
> I would really appreciate if you could go through the questions I
> asked back then, and enlighten me.

It turns out I never even archived the messages, so I can easily go
through them from my (rather bloated) inbox and see if we can get some
photons flowing.

I'll start on that momentarily.

Regards,
Branden

signature.asc
Description: PGP signature