[Rdiff-backup-bugs] [bug #21202] Crash : AssertionError: no ownership of ...

[Andrew Ferguson]

Update of bug #21202 (project rdiff-backup):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #6:

Ok, I have done some tests and found that:
1) Doing try/except costs about 3-4x if/else
2) No noticeable penalty is paid for setting up try/except if you don't take
the except branch (because no exception was raised)

Thus, I have simply changed the previous except: block to re-try the chmod
and operation. If it fails again, then it says that permission is denied.

For AFS, this means that the chmod() is tried in the error handler, and will
work in setups like Marc's. For other filesystems, it means that no penalty is
paid for this behavior, since the original if clause is making the only
effective chmod() statement.

In summary:
- AFS pays the performance penalty that Marc proposed
- Non-AFS pays a 2x penalty, but only when the file cannot be opened,
otherwise it pays no penalty. Since the former case is presumably rare, the
overall penalty is minimized.

See version 1.45 of backup.py in CVS.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21202>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/